deploy: set condition reason correctly for new RCs #11609
Conversation
|
[test] |
| if err == wait.ErrWaitTimeout { | ||
| err = fmt.Errorf("deployment config %q never updated its conditions: %#v", name, conditions) | ||
| } | ||
| o.Expect(err).NotTo(o.HaveOccurred()) |
There was a problem hiding this comment.
as some point (and we are getting to that point now) we should split this file :-)
| value: wvXqW5E0 | ||
| - name: MYSQL_DATABASE | ||
| value: root | ||
| image: openshift/mysql-55-centos7:latest |
There was a problem hiding this comment.
use openshift/origin here (it does not matter for this test, but we don't want somebody to copy&paste this in a test that will actually pull this.
|
LGTM (but fix the image in fixture before merging) |
|
@mfojtik fixture fixed, ptal |
|
Evaluated for origin test up to 24fa302 |
|
[merge] |
|
Evaluated for origin merge up to 24fa302 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10720/) (Base Commit: 125ed10) |
|
test job flaked on #11616 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10777/) (Base Commit: 1d47b2b) (Image: devenv-rhel7_5263) |
@mfojtik oversight, ptal