oc cluster up doc update #11624
oc cluster up doc update #11624
Conversation
|
@coreydaley ptal ... this depends on #11585 |
|
@csrwng I think that we should settle on a format for the version in this PR, either 1.3.x or 1.3+, and not keep going back and forth, as it could be confusing. It probably doesn't really matter which one is chosen, as long as we are consistent. |
|
|
|
@stevekuznetsov I mis-typed, it is actually choosing between "1.3.x or newer releases" and "1.3+", which would be similar, but using 1.3+ is much more succinct and less likely to be misinterpreted. |
| NOTE - this command was released with the 1.3+ version of oc client tools, so you must be using version 1.3+ or above for this command to work. | ||
| | NOTE | | ||
| | ---- | | ||
| | This command was released with the 1.3+ version of oc client tools, so you must be using version 1.3+ or above for this command to work. | |
There was a problem hiding this comment.
I guess the "or above" here is redundant as well, will fix.
csrwng
force-pushed
the
clusterup_doc_update
branch
from
ebe16dc to
6c79104
Compare
|
updated, but wasn't sure about removing the "or newer" part because it could be interpreted as 1.3 but not 1.4 ? |
openshift-bot
added
the
needs-rebase
csrwng
force-pushed
the
clusterup_doc_update
branch
from
6c79104 to
8ee60e2
Compare
|
updated and rebased, ptal again |
openshift-bot
removed
the
needs-rebase
|
@csrwng looks good to me |
|
@bparees ptal |
|
|
||
| | WARNING | | ||
| | ------- | | ||
| | In some cases, networking for pods will not work for containers in your cluster, especially in Fedora 24. To fix this, run `$ sudo iptables -F` before running `oc cluster up` | |
There was a problem hiding this comment.
explain that this will flush the iptables. I don't like to run random sudo commands on my machine if i don't know what it's supposed to do :)
|
|
||
| | NOTE | | ||
| | ---- | | ||
| | This feature requires an oc command v1.4 and newer | |
|
two nits and lgtm |
csrwng
force-pushed
the
clusterup_doc_update
branch
2 times, most recently
from
a882367 to
33a5dfb
Compare
|
comments addressed |
| - [Linux](#linux) | ||
| - [Mac OS with Docker for Mac](#mac-os-with-docker-for-mac) |
There was a problem hiding this comment.
Should be Max OS X same as the one below it
There was a problem hiding this comment.
The latest version of Mac OS dropped the "X" ... and Docker for Mac only supports this latest version.
docker-machine can be run on OS X
There was a problem hiding this comment.
I will defer to your mac-spertise
There was a problem hiding this comment.
actually, it should be MacOS, will fix
|
@csrwng added a couple small nits |
csrwng
force-pushed
the
clusterup_doc_update
branch
from
33a5dfb to
ee6ce02
Compare
csrwng
force-pushed
the
clusterup_doc_update
branch
from
ee6ce02 to
95e1853
Compare
|
Updated |
|
[merge] |
|
Evaluated for origin merge up to 95e1853 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 95e1853 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10802/) (Base Commit: 90c7b56) |
|
Flake #11650 re-[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10823/) (Base Commit: ef95fd9) (Image: devenv-rhel7_5274) |
Adds explicit doc for Docker for Mac, Docker for Windows and adds iptables -F suggestion for Linux.