Better 'oc run' validations

[fabianofranz]

Fixes #11605
Upstream PR: kubernetes/kubernetes#35732

Adds more validations to flags that must be mutually exclusive in oc run. For example, --dry-run must not be used with --attach, --stdin, or --tty, that doesn't make sense.

[fabianofranz]

[test]

[fabianofranz]

@openshift/cli-review

[openshift-bot]

Evaluated for origin test up to 23f62eb

[liggitt]

I'm still curious what data flow led to the args being used as a selector and all-namespaces being queried.

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10766/) (Base Commit: 0403599)

[fabianofranz]

@liggitt I didn't dig too deep, but I believe it's related to calling AttachablePodForObject with an object that was not really created and doesn't have a namespace set.

[fabianofranz]

with an object that was not really created and doesn't have a namespace set

@liggitt because it only happens with --dry-run

[fabianofranz]

[merge]

[openshift-bot]

Evaluated for origin merge up to 23f62eb

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10766/) (Base Commit: 8b2d509) (Image: devenv-rhel7_5278)