UPSTREAM: 34434: Print valid json/yaml output in oc set image
#11664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanvallejo
changed the title
oc set imageoc set image
juanvallejo
force-pushed
the
jvallejo/fix-oc-set-image-output
branch
from
28dfbc5 to
5ad9bcf
Compare
|
[test] |
This patch updates `oc set image` to print the info `running in local mode...` through stderr in order to allow only json or yaml output when using the `--local` flag.
juanvallejo
force-pushed
the
jvallejo/fix-oc-set-image-output
branch
from
5ad9bcf to
429f299
Compare
|
Evaluated for origin test up to 429f299 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10912/) (Base Commit: df195a9) |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10912/) (Image: devenv-rhel7_5291) |
|
Evaluated for origin merge up to 429f299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related UPSTREAM: kubernetes/kubernetes#34434
Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1390140
This patch updates
oc set imageto print the inforunning in local mode...through stderr in order to allow only json or yaml output whenusing the
--localflag.This patch also prevents a potential panic here, by assigning a non-nil value to
o.Errinset_image.go.@openshift/cli-review