Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EgressNetworkPolicy match-all-IPs special case #11673

Merged

Conversation

danwinship
Copy link
Contributor

OVS doesn't let you say nw_dst=0.0.0.0/0; you have to just not specify nw_dst instead. We had a workaround for this, except it was backwards...

@openshift/networking PTAL

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM [test]

Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knobunc
Copy link
Contributor

knobunc commented Nov 1, 2016

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 757d272

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 757d272

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10910/) (Base Commit: df195a9)

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 1, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10943/) (Base Commit: f55922e) (Image: devenv-rhel7_5291)

@openshift-bot openshift-bot merged commit 16306a6 into openshift:master Nov 1, 2016
@danwinship danwinship deleted the fix-egress-network-policy branch November 2, 2016 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants