Fix oauth redirect ref in jenkins service account #11681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bparees @gabemontero ptal |
|
LGTM |
|
though you'll need to run the update bindata command with the template change |
csrwng
force-pushed
the
fix-jenkins-persistent-sa
branch
from
a66ba4e to
3cf72ca
Compare
|
thx for reminding me, updated |
|
#10663 |
|
Evaluated for origin test up to 3cf72ca |
|
lgtm [merge] |
|
Evaluated for origin merge up to 3cf72ca |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10931/) (Base Commit: 3b97ee7) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10966/) (Base Commit: 8ecb3f5) (Image: devenv-rhel7_5294) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the redirect reference annotation for the Jenkins service account in the persistent template the same as the one in the ephemeral template:
https://github.com/openshift/origin/blob/master/examples/jenkins/jenkins-ephemeral-template.json#L161