new-app: validate non-numeric EXPOSE directive when strategy wasn't specified #11687
Conversation
…OSE directive (when strategy wasn't specified). (Finally) fixes https://bugzilla.redhat.com/show_bug.cgi?id=1365986
| @@ -901,7 +901,7 @@ func optionallyValidateExposedPorts(config *AppConfig, repositories app.SourceRe | |||
| return nil | |||
| } | |||
|
|
|||
| if config.Strategy != "docker" { | |||
| if len(config.Strategy) > 0 && config.Strategy != "docker" { | |||
There was a problem hiding this comment.
there are cases where the strategy is not explicitly specified but new-app detects the build type as dockerfile because a Dockerfile is present in the repo, is this going to handle that properly?
There was a problem hiding this comment.
Yes, but in this case the type will be docker (and not dockerfile). In other words, empty strategy is the same as docker strategy.
|
flake #10566 |
1 similar comment
|
flake #10566 |
|
Are you seeing those flakes on Jenkins? Otherwise, that is an abuse of the flake tagging feature and you should not be using that to get new tests... |
|
lgtm [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10929/) (Image: devenv-rhel7_5291) |
|
Evaluated for origin merge up to 1433dda |
|
flake #11661 |
|
Evaluated for origin test up to 1433dda |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10929/) (Base Commit: 3b97ee7) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1365986
Follow-up to: #10677
PTAL @bparees