Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dind: fix /run mount prop for docker 1.12 compat #11720

Closed
wants to merge 1 commit into from
Closed

dind: fix /run mount prop for docker 1.12 compat #11720

wants to merge 1 commit into from

Conversation

marun
Copy link
Contributor

@marun marun commented Nov 2, 2016

As per #11707, docker 1.12 requires the /run volume to have shared mount propagation enabled.

@marun
Copy link
Contributor Author

marun commented Nov 2, 2016

[test] [testextended][extended:networking]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e68cbb6

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to e68cbb6

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10970/) (Base Commit: 90d8c62)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/723/) (Base Commit: 90d8c62) (Extended Tests: networking)

@marun
Copy link
Contributor Author

marun commented Nov 2, 2016

Test failure is unrelated, this is ready to merge.

cc: @openshift/networking

@rajatchopra
Copy link
Contributor

[merge]

knobunc
knobunc approved these changes Nov 2, 2016
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @marun

@knobunc
Copy link
Contributor

knobunc commented Nov 2, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 2, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 4

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e68cbb6

@dcbw
Copy link
Contributor

dcbw commented Nov 2, 2016

LGTM, though if my PR gets in first this one will be a NOP.

@marun
Copy link
Contributor Author

marun commented Nov 3, 2016

Looks like #11613 has merged, so this is no longer necessary.

@marun marun closed this Nov 3, 2016
@marun marun deleted the dind-docker1.12-mount-prop branch November 3, 2016 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatchopra rajatchopra rajatchopra approved these changes

@knobunc knobunc knobunc approved these changes

Assignees
No one assigned
Labels
component/networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marun @openshift-bot @rajatchopra @knobunc @dcbw