-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM 35285: Remove stale volumes if endpoint/svc creation fails. #11722
UPSTREAM 35285: Remove stale volumes if endpoint/svc creation fails. #11722
Conversation
Signed-off-by: Humble Chirammal <[email protected]>
294f98d
to
9f1504a
Compare
If this isn't fixing a blocker bug and it didn't land in 1.4 I'm against it. |
@soltysh this is a blocker bug fix. Without this fix, the underlying storage will run out of space if there is an error in endpoint/svc creation . Also its very difficult to track the culprit from admin point of view. |
Please provide a link to the bz in the PR description if you can |
@ncdc Done. Please let me know if you need more details on this. Thanks! |
This is merged upstream but after 1.4 |
[test] |
👍 for merge |
Evaluated for origin test up to 9f1504a |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11029/) (Base Commit: cf6ed4b) |
1 similar comment
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11029/) (Base Commit: cf6ed4b) |
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11029/) (Image: devenv-rhel7_5309) |
Evaluated for origin merge up to 9f1504a |
Bug# https://bugzilla.redhat.com/show_bug.cgi?id=1388868
Signed-off-by: Humble Chirammal [email protected]