Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM 35285: Remove stale volumes if endpoint/svc creation fails. #11722

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Nov 2, 2016

@humblec
Copy link
Contributor Author

humblec commented Nov 2, 2016

@rootfs @jsafrane PTAL.

@humblec humblec force-pushed the glusterfs-backport-35285 branch from 294f98d to 9f1504a Compare November 2, 2016 09:34
@pweil-
Copy link

pweil- commented Nov 2, 2016

@childsb @eparis please add sign off/justification before merge as this is not in the upstream 1.4 branch. Thanks

(cc @ncdc @soltysh)

@soltysh
Copy link
Contributor

soltysh commented Nov 2, 2016

If this isn't fixing a blocker bug and it didn't land in 1.4 I'm against it.

@humblec
Copy link
Contributor Author

humblec commented Nov 2, 2016

@soltysh this is a blocker bug fix. Without this fix, the underlying storage will run out of space if there is an error in endpoint/svc creation . Also its very difficult to track the culprit from admin point of view.

@ncdc
Copy link
Contributor

ncdc commented Nov 2, 2016

Please provide a link to the bz in the PR description if you can

@humblec
Copy link
Contributor Author

humblec commented Nov 2, 2016

@ncdc Done. Please let me know if you need more details on this. Thanks!

@childsb
Copy link
Contributor

childsb commented Nov 2, 2016

@childsb
Copy link
Contributor

childsb commented Nov 2, 2016

This is merged upstream but after 1.4

@childsb
Copy link
Contributor

childsb commented Nov 2, 2016

[test]

@soltysh
Copy link
Contributor

soltysh commented Nov 2, 2016

@soltysh this is a blocker bug fix

👍 for merge

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9f1504a

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11029/) (Base Commit: cf6ed4b)

1 similar comment
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11029/) (Base Commit: cf6ed4b)

@childsb
Copy link
Contributor

childsb commented Nov 3, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 3, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11029/) (Image: devenv-rhel7_5309)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 9f1504a

@openshift-bot openshift-bot merged commit 4c42240 into openshift:master Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants