Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CleanupHostPathVolumes(): fetch meta info before removing PV #11737

Merged
merged 1 commit into from
Nov 3, 2016
Merged

CleanupHostPathVolumes(): fetch meta info before removing PV #11737

merged 1 commit into from
Nov 3, 2016

Conversation

php-coder
Copy link
Contributor

It doesn't affect tests behavior, only cleanup procedure.

Bugfix for #11489

PTAL @bparees

@php-coder
Copy link
Contributor Author

[testextended][extended:core(petset)]

@bparees
Copy link
Contributor

bparees commented Nov 2, 2016

lgtm, will see what the tests show.

@php-coder
Copy link
Contributor Author

@bparees I'm expecting that the messages WARNING: couldn't get meta info for PV ... won't be shown.

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 208a7cc

@bparees
Copy link
Contributor

bparees commented Nov 2, 2016

@bparees I'm expecting that the messages WARNING: couldn't get meta info for PV ... won't be shown.

i just meant "let's see if the tests pass before merging"

@bparees bparees self-assigned this Nov 2, 2016
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/726/) (Base Commit: a1a3097) (Extended Tests: core(petset))

@php-coder
Copy link
Contributor Author

This failure will be fixed after merging #11739

@bparees
Copy link
Contributor

bparees commented Nov 3, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 3, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11081/) (Image: devenv-rhel7_5309)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 208a7cc

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 208a7cc

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11081/) (Base Commit: 6abb256)

@openshift-bot openshift-bot merged commit bd10b35 into openshift:master Nov 3, 2016
@php-coder php-coder deleted the fix_pvs_cleanup branch November 3, 2016 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bparees bparees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@php-coder @bparees @openshift-bot