f5 node watch fix - needs a cache to process 'MODIFY' events #11742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
[test] |
|
Evaluated for origin test up to 315c2e4 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11032/) (Base Commit: 2583f1e) |
|
[merge] |
1 similar comment
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11032/) (Image: devenv-rhel7_5306) |
|
Evaluated for origin merge up to 315c2e4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poor code before, never accounted that nodes that were already created before F5 is launched will only get a MODIFIED event. This code takes care of that (and ignores the subsequent MODIFY events caused by status updates).
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1389706
@pravisankar Please review. Thanks for the hint.
cc @openshift/networking