Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to unlink deleted secrets from a service account #11868

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Allow to unlink deleted secrets from a service account #11868

merged 1 commit into from
Dec 15, 2016

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Nov 10, 2016

Fixes: #11851

@fabianofranz PTAL this improves a logic around linking/unlinking the secrets a little bit:

[@dev] .../openshift/origin # oc create secret generic test --from-literal=foo=bar
secret "test" created
[@dev] .../openshift/origin # oc secrets unlink builder test
error: No valid secrets found or secrets not linked to service account
[@dev] .../openshift/origin # oc secrets link builder test
[@dev] .../openshift/origin # oc delete secret test
secret "test" deleted
[@dev] .../openshift/origin # oc secrets unlink builder test
secret "test" not found
error: Unlinked deleted secrets from test/builder service account
[@dev] .../openshift/origin # oc secrets unlink builder test
secret "test" not found
error: No valid secrets found or secrets not linked to service account
[@dev] .../openshift/origin # oc secrets link builder test
secret "test" not found
error: No valid secrets found

@mfojtik mfojtik mentioned this pull request Nov 10, 2016
Closed
@mfojtik
Copy link
Contributor Author

mfojtik commented Nov 10, 2016

[test]

@mfojtik mfojtik force-pushed the unlink-deleted-secrets branch from e30bdec to 94acadc Compare November 10, 2016 13:08
@mfojtik mfojtik force-pushed the unlink-deleted-secrets branch from 94acadc to 4443e8f Compare November 10, 2016 13:13
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4443e8f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11364/) (Base Commit: ab8b232)

@fabianofranz
Copy link
Member

LGTM

@mfojtik mfojtik added this to the 1.5.0 milestone Nov 11, 2016
@mfojtik
Copy link
Contributor Author

mfojtik commented Nov 11, 2016

will wait for 1.5 to merge.

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 15, 2016

[merge]

@mfojtik
Copy link
Contributor Author

mfojtik commented Dec 15, 2016

flake: #10773

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 4443e8f

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12415/) (Base Commit: da967d5) (Image: devenv-rhel7_5550)

@openshift-bot openshift-bot merged commit 92a2d6f into openshift:master Dec 15, 2016
@mfojtik mfojtik deleted the unlink-deleted-secrets branch September 5, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mfojtik @openshift-bot @fabianofranz