Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide DockerImageConfig as well as DockerImageManifest #12004

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Hide DockerImageConfig as well as DockerImageManifest #12004

merged 1 commit into from
Jan 17, 2017

Conversation

legionus
Copy link
Contributor

Fix #11974

@legionus legionus force-pushed the remove-dockerImageConfig-from-imagestreamtag-imagestreamimage branch from 0aa7f94 to 8da1554 Compare January 11, 2017 13:14
@legionus
Copy link
Contributor Author

[test]

@legionus
Copy link
Contributor Author

flake #11887
re[test]

@legionus
Copy link
Contributor Author

@smarterclayton @miminar PTAL

@legionus legionus changed the title [WIP] Hide DockerImageConfig as well as DockerImageManifest Hide DockerImageConfig as well as DockerImageManifest Jan 12, 2017
miminar
miminar reviewed Jan 12, 2017
View reviewed changes
Copy link

@miminar miminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can some tests be included though?

@legionus legionus force-pushed the remove-dockerImageConfig-from-imagestreamtag-imagestreamimage branch from 8da1554 to 1b747ae Compare January 16, 2017 16:39
@legionus
Copy link
Contributor Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 1b747ae

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12904/) (Base Commit: 8e57c4b)

@legionus
Copy link
Contributor Author

@miminar done.
@mfojtik merge?

@mfojtik
Copy link
Contributor

mfojtik commented Jan 17, 2017

LGTM as well

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 1b747ae

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 17, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12937/) (Base Commit: 9a57e87) (Image: devenv-rhel7_5697)

@openshift-bot openshift-bot merged commit 8c82e8f into openshift:master Jan 17, 2017
@l0rd l0rd mentioned this pull request Mar 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miminar miminar miminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legionus @openshift-bot @mfojtik @miminar