add login warning if cannot list or create projectrequests #12008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@openshift/cli-review @liggitt ptal |
|
[test] |
juanvallejo
force-pushed
the
jvallejo/warn-on-login-if-user-cannot-list-projects
branch
2 times, most recently
from
3aaa9e8 to
a49a4f2
Compare
|
Needs |
This patch adds a check to see if the user cannot list `projectrequests`, in addition to create `projectrequests`. This warning showed up previously only when a user did not have a `self-provisioner` role, however, it faield to show up if the user did have a `self-provisioner` role but was unable to list `projectrequests`.
juanvallejo
force-pushed
the
jvallejo/warn-on-login-if-user-cannot-list-projects
branch
from
c848ffc to
edf8423
Compare
|
Evaluated for origin test up to edf8423 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11784/) (Base Commit: 7ec2f67) |
1 similar comment
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11784/) (Base Commit: 7ec2f67) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11784/) (Image: devenv-rhel7_5446) |
|
Evaluated for origin merge up to edf8423 |
juanvallejo
deleted the
jvallejo/warn-on-login-if-user-cannot-list-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: https://github.com/openshift/origin/pull/11904/files
Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1262696
This patch adds a check to see if the user cannot list
projectrequests,in addition to create
projectrequests. This warning showed up previouslyonly when a user did not have a
self-provisionerrole, however, itfaield to show up if the user did have a
self-provisionerrole butwas unable to list
projectrequests.Before
After
cc @xiaocwan @fabianofranz