Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consideration of imagePullPolicy on lifecycle hook execution #12080

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Consideration of imagePullPolicy on lifecycle hook execution #12080

merged 1 commit into from
Dec 2, 2016

Conversation

VanRoy
Copy link
Contributor

@VanRoy VanRoy commented Nov 30, 2016

For fixes #12079

pweil-
pweil- reviewed Nov 30, 2016
View reviewed changes
pkg/deploy/strategy/support/lifecycle.go
WorkingDir: baseContainer.WorkingDir,
Env: mergedEnv,
Resources: resources,
VolumeMounts: volumeMounts,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kargakis should we be passing along other fields as well like SecurityContext settings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kargakis , @pweil- , Do you want that i amend my PR with the other fields ? Can you list me all fields that you want to add ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VanRoy created #12103 to make sure we follow up on it. No need to add it here.

@0xmichalis
Copy link
Contributor

@VanRoy created #12103 to make sure we follow up on it. No need to add it here.

Agreed. LGTM [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 33eab71

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11891/) (Base Commit: 622ed43)

@0xmichalis
Copy link
Contributor

#10988 [merge]

@0xmichalis
Copy link
Contributor

#12112 [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 33eab71

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11924/) (Base Commit: 7b90443) (Image: devenv-rhel7_5465)

@openshift-bot openshift-bot merged commit 1023112 into openshift:master Dec 2, 2016
@VanRoy
Copy link
Contributor Author

VanRoy commented Dec 2, 2016

Hi @Kargakis , @pweil- , thanks for your rapid taking into account of my contribution.
Do you have any idea if this fix will be included in the next OCP 3.4 release ?

@pweil- pweil- mentioned this pull request Dec 2, 2016
Merged
@pweil-
Copy link

pweil- commented Dec 2, 2016

@VanRoy I have created #12121 for consideration in the 1.4 branch.

@Kargakis merge is assigned to you. PTAL

@VanRoy
Copy link
Contributor Author

VanRoy commented Dec 2, 2016

@pweil- Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmichalis 0xmichalis 0xmichalis left review comments

@pweil- pweil- pweil- left review comments

Assignees

@0xmichalis 0xmichalis

Labels
priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifecycle hooks not use imagePullPolicy
4 participants
@VanRoy @0xmichalis @openshift-bot @pweil-