Add advanced pipeline examples #12177

csrwng · 2016-12-07T22:39:46Z

Adds 2 more pipeline examples to origin. Updates the existing README with instructions for the examples.

csrwng · 2016-12-07T22:41:01Z

bparees

would like to see this driven entirely via the openshift webconsole, since that should be possible.

bparees · 2016-12-07T22:48:55Z

examples/jenkins/pipeline/README.md


    If you monitor the pods in your default project, you will also see the slave pod get created and deleted.
+
+
+## Pipeline of Pipelines Example


Orchestration Pipeline Example sounds nicer :)

bparees · 2016-12-07T22:50:46Z

examples/jenkins/pipeline/README.md

+   oc new-project mapsapp
+   ```
+
+3. To instantiate the pipeline via the Web Console, create the template from this directory first:


you can just instantiate it in the console via the "upload" path instead of installing/registering it.

bparees · 2016-12-07T22:51:21Z

examples/jenkins/pipeline/README.md

+1. Ensure that you have a running OpenShift environment as described in the basic example
+2. Create a new project for your pipeline:
+   ```
+   oc new-project mapsapp


do this from the web console

bparees · 2016-12-07T22:52:51Z

examples/jenkins/pipeline/README.md

+7. Navigate to *Builds* -> *Pipelines*
+8. Click on *Start Pipeline*
+
+The pipeline will instantiate other pipelines and those will in turn instantiate OpenShift objects. 


it's going to take some time for jenkins to come up before the pipeline will start, probably worth warning users about that so they aren't immediately wondering why it's not running.

(and making it clear that's a first time only thing)

bparees · 2016-12-07T22:53:48Z

examples/jenkins/pipeline/README.md

+
+## Blue Green Deployment Example
+
+The `bluegreen-pipeline.yaml` template contains a pipeline that demonstrates alternating blue/green deployments.


with a manual confirmation/approval step.

bparees · 2016-12-07T22:54:11Z

examples/jenkins/pipeline/README.md

+2. Create a new project for your pipeline:
+   ```
+   oc new-project bluegreen
+   ```


via webconsole

bparees · 2016-12-07T22:54:38Z

examples/jenkins/pipeline/README.md

+4. Modify the *Git Repository URL* to contain the URL of your fork
+5. Click on *Create*
+6. Navigate to *Builds* -> *Pipelines*
+7. Click on *Start Pipeline*


(wait for jenkins to start up...then pipeline will run...)

bparees · 2016-12-07T22:55:45Z

examples/jenkins/pipeline/README.md

+5. Click on *Create*
+6. Navigate to *Builds* -> *Pipelines*
+7. Click on *Start Pipeline*
+8. Once code has been deployed, the pipeline will pause for your approval. Click on the pause icon to approve the pipeline.


s/approve the pipeline/approve deployment of the changes/

bparees · 2016-12-07T22:58:52Z

examples/jenkins/pipeline/samplepipeline.yaml

@@ -0,0 +1,327 @@
+apiVersion: v1


did you convert samplepipeline.json to yaml? if so, let's delete the json one. (might need to make sure no tests are referencing it)

samplepipeline.json removed. I didn't find any tests that referred to it. Only the cluster up code, which I fixed up.

bparees · 2016-12-07T23:03:34Z

@csrwng I feel like this part of the card has gotten neglected in these samples (I know you included it in your other CI sample):

4) use slave pods/images

something else to consider:
Instead of defining a buildconfig in openshift, perform the actual maven build within the slave and then take that war and submit it for a binary build to openshift.  (or push the war to a nexus repo and pull it from there for assembling the app image)


Notes:
-----------------------------------------
Currently there is one pipeline sample that doesn't align or leverage or supplied slave images. By supplying these samples, it will better highlight how we intend our end users to use our supplied builder slaves.

Is there something we can do either to the original samplepipeline.json/yaml, or one of these 2 samples, to better cover demonstrating using a slave node for its intended purpose?

csrwng · 2016-12-08T14:43:05Z

Is there something we can do either to the original samplepipeline.json/yaml, or one of these 2 samples, to better cover demonstrating using a slave node for its intended purpose?

I will switch the bluegreen pipeline to use the nodejs slave for building

csrwng · 2016-12-08T21:35:59Z

I added a new pipeline that uses a maven slave to build a WAR

bparees · 2016-12-08T21:40:20Z

examples/jenkins/pipeline/maven-pipeline.yaml

+      dockerfile: |-
+        FROM wildfly
+        COPY ROOT.war /opt/app-root/src/target/ROOT.war
+        RUN $STI_SCRIPTS_PATH/assemble


do you really need to run assemble vs just copying the war directly into the deployment dir?

bparees · 2016-12-08T21:41:17Z

examples/jenkins/pipeline/README.md

+## Maven Slave Example
+
+The `maven-pipeline.yaml` template contains a pipeline that uses a maven node to build and package a WAR.
+It then builds an image with the WAR using a Docker build.


using a Docker-strategy OpenShift build.

bparees · 2016-12-08T21:42:16Z

examples/jenkins/pipeline/README.md

+10. Navigate to *Builds* -> *Pipelines*
+11. Click on *Start Pipeline* next to *openshift-jee-sample*
+
+When the pipeline completes, the openshift-jee-sample application should be deployed and running.


same comment you have below about waiting for jenkins the first time.

bparees · 2016-12-08T21:42:40Z

examples/jenkins/pipeline/README.md

+8. Modify the *Git Repository URL* to contain the URL of your fork
+9. Click on *Create*
+10. Navigate to *Builds* -> *Pipelines*
+11. Click on *Start Pipeline* next to *bluegreen-pipeline*


same comment you have above about waiting for jenkins the first time.

i think you missed this one?

now it's fixed. Also added some text to explain how the routes work with this example.

bparees

couple of nits but otherwise lgtm.

csrwng · 2016-12-08T23:19:22Z

comments addressed

bparees · 2016-12-09T15:54:57Z

lgtm [merge]

openshift-bot · 2016-12-09T16:05:34Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12199/) (Image: devenv-rhel7_5516)

openshift-bot · 2016-12-09T16:05:34Z

Evaluated for origin merge up to d0b9dc7

openshift-bot · 2016-12-09T16:05:34Z

[Test]ing while waiting on the merge queue

openshift-bot · 2016-12-09T16:13:21Z

Evaluated for origin test up to d0b9dc7

openshift-bot · 2016-12-09T17:38:17Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12199/) (Base Commit: cbc0af0)

bparees self-assigned this Dec 7, 2016

bparees requested changes Dec 7, 2016

View reviewed changes

csrwng force-pushed the pipeline-examples branch from 0ffaf2c to b84360a Compare December 8, 2016 14:40

csrwng force-pushed the pipeline-examples branch 2 times, most recently from 76e0703 to 22121a4 Compare December 8, 2016 21:35

bparees reviewed Dec 8, 2016

View reviewed changes

bparees requested changes Dec 8, 2016

View reviewed changes

csrwng force-pushed the pipeline-examples branch from 22121a4 to 77f941f Compare December 8, 2016 23:19

Add advanced pipeline examples

d0b9dc7

csrwng force-pushed the pipeline-examples branch from 77f941f to d0b9dc7 Compare December 9, 2016 14:05

openshift-bot merged commit 1b0d264 into openshift:master Dec 9, 2016

csrwng deleted the pipeline-examples branch December 21, 2016 20:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add advanced pipeline examples #12177

Add advanced pipeline examples #12177

csrwng commented Dec 7, 2016

csrwng commented Dec 7, 2016

bparees left a comment

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

bparees Dec 7, 2016

csrwng Dec 8, 2016

bparees commented Dec 7, 2016

csrwng commented Dec 8, 2016

csrwng commented Dec 8, 2016

bparees Dec 8, 2016

bparees Dec 8, 2016 •

edited

Loading

bparees Dec 8, 2016

bparees Dec 8, 2016

bparees Dec 8, 2016

csrwng Dec 9, 2016

bparees left a comment

csrwng commented Dec 8, 2016

bparees commented Dec 9, 2016

openshift-bot commented Dec 9, 2016 •

edited

Loading

openshift-bot commented Dec 9, 2016

openshift-bot commented Dec 9, 2016

openshift-bot commented Dec 9, 2016

openshift-bot commented Dec 9, 2016


		If you monitor the pods in your default project, you will also see the slave pod get created and deleted.


		## Pipeline of Pipelines Example


		## Blue Green Deployment Example

		The `bluegreen-pipeline.yaml` template contains a pipeline that demonstrates alternating blue/green deployments.

Add advanced pipeline examples #12177

Add advanced pipeline examples #12177

Conversation

csrwng commented Dec 7, 2016

csrwng commented Dec 7, 2016

bparees left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bparees commented Dec 7, 2016

csrwng commented Dec 8, 2016

csrwng commented Dec 8, 2016

Choose a reason for hiding this comment

bparees Dec 8, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bparees left a comment

Choose a reason for hiding this comment

csrwng commented Dec 8, 2016

bparees commented Dec 9, 2016

openshift-bot commented Dec 9, 2016 • edited Loading

openshift-bot commented Dec 9, 2016

openshift-bot commented Dec 9, 2016

openshift-bot commented Dec 9, 2016

openshift-bot commented Dec 9, 2016

bparees Dec 8, 2016 •

edited

Loading

openshift-bot commented Dec 9, 2016 •

edited

Loading