rework build list order for oc status #12179
Conversation
|
@openshift/cli-review |
|
[test] |
| // display the last successful build if specifically requested or we're going to display an active build for context | ||
| if lastSuccessfulBuild != nil && (includeSuccess || len(activeBuilds) > 0) { | ||
| out = append(out, describeBuildPhase(lastSuccessfulBuild.Build, &passTime, build.BuildConfig.Name, pushTargetResolved)) |
There was a problem hiding this comment.
do you actually need to check if lastSuccessBuild!=nil? seems like all this logic works fine even if "firstBuildToDisplay" or "secondBuildToDisplay" ends up getting assigned "nil"
There was a problem hiding this comment.
Yep, that looks right on second glance ... I'll push an update in a bit.
|
The yum repo / mirror issues bit the test run. I'll trigger a new one in a bit. |
gabemontero
force-pushed
the
issue6421
branch
from
0e81921 to
cabcd46
Compare
gabemontero
force-pushed
the
issue6421
branch
from
cabcd46 to
1060f05
Compare
|
Evaluated for origin test up to 1060f05 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12188/) (Base Commit: 5e81dae) |
|
Cool, mirrors fixed and test passing. Merge?
…On Fri, Dec 9, 2016 at 9:11 AM OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test SUCCESS (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12188/) (Base
Commit: 5e81dae
<5e81dae>
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12179 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADbadHYES2KZQgIx2AyGHQxm3xpQ8HsCks5rGWGVgaJpZM4LHRvH>
.
|
|
lgtm [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12188/) (Image: devenv-rhel7_5515) |
|
Evaluated for origin merge up to 1060f05 |
Fixes #6421
@deads2k PTAL
@bparees FYI