Don't show the project DisplayName when short #12274
Conversation
|
LGTM @openshift/cli-review |
|
I would also expect this output to be suppressed when -q is used. |
|
@jupierce thanks, I have updated my commit |
| case 1: | ||
| if o.DisplayShort { | ||
| msg += fmt.Sprintf("%s", api.DisplayNameAndNameForProject(&projects[0])) | ||
| msg += fmt.Sprintf("%s", &projects[0].Name) |
There was a problem hiding this comment.
nit, but & is not needed here, it can just be projects[0].name
|
One nit, but otherwise lgtm |
When using the short option, show ony the project name without the DisplayName to stay consistent for scripting. Don't display msg about non membership of a project as well when using the short option to project. Fixes #12267
|
[test] |
|
@juanvallejo yep thanks, i have updated the commit. |
|
Evaluated for origin test up to 9baf430 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12416/) (Base Commit: da967d5) |
|
the CI seems to fails on :
bash: line 7: hack/build-dind-images.sh: Permission denied
I guess this is a known issue?
|
|
[merge] |
|
Evaluated for origin merge up to 9baf430 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12441/) (Base Commit: fb483eb) (Image: devenv-rhel7_5554) |
When using the short option, show ony the project name without the
DisplayName to stay consistent for scripting.
Fixes #12267