Make the DIND image creation script executable #12282
Conversation
Signed-off-by: Steve Kuznetsov <[email protected]>
|
@marun FYI [merge] |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 5 |
|
Evaluated for origin merge up to 380a99f |
|
[Test]ing while waiting on the merge queue |
|
arg, sorry! |
|
Evaluated for origin test up to 380a99f |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12433/) (Base Commit: 252be46) |
|
hit the big green button to unblock queue. |
|
@smarterclayton why are we building the base images inside of our test jobs? I thought the whole point was to do that in the AMI? Initially I thought this was not a huge issue but it was failing PR test jobs, not just the base/devenv. /cc @danmcp |
|
Occasionally someone needs to change it. It's something that is more
coupled to our process than the release image, but could be handled
separately. I'm open to kicking it to base ami completely as long as we
have a way to update it.
|
AFAICT the only reason we have two image building scripts is that one should not be running in our tests since it builds the base images.
That being said, I don't think we do have a toggle for this at run-time, so yeah, this was perhaps not thought all the way through whenever it was implemented in the first place. |
|
Originally it used the docker cache - so rebuild was a no-op. Not the case
with imagebuilder.
|
Signed-off-by: Steve Kuznetsov [email protected]