Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespace selector field to crq describe output #12292

Conversation

juanvallejo
Copy link
Contributor

Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1400912

This patch adds a Namespace Selector field to the describer output of clusterresourcequota to display the list of namespaces that are selected based on the clusterresourcequota's --project-anotation-selector.

Example

$ oc create clusterresourcequota crq-1 --project-annotation-selector=openshift.io/requester=user --hard=secrets=50

$ oc new-project p-1 --as=user
$ oc new-project p-2 --as=user
$ oc new-project p-3 --as=dev

$ oc describe clusterresourcequota crq-1
Name:           crq-1
Namespace:      <none>
Created:        52 minutes ago
Labels:         <none>
Annotations:    <none>
Namespace Selector: ["p-1" "p-2"]
Label Selector: <null>
AnnotationSelector: map[openshift.io/requester:user]
Resource        Used    Hard
--------        ----    ----
secrets         18      50

@openshift/cli-review

@juanvallejo
Copy link
Contributor Author

[test]

@fabianofranz
Copy link
Member

LGTM [merge]

@juanvallejo
Copy link
Contributor Author

check flaked on #11024 re[test]

@juanvallejo
Copy link
Contributor Author

conformance check flaked on #11662 re[test]

@juanvallejo
Copy link
Contributor Author

conformance flaked on #11662 re[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to b1a84eb

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12551/) (Base Commit: 79cccd7)

@juanvallejo
Copy link
Contributor Author

@fabianofranz could you re-tag please?

@fabianofranz
Copy link
Member

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to b1a84eb

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12570/) (Base Commit: 1134ff1) (Image: devenv-rhel7_5585)

@openshift-bot openshift-bot merged commit 81cccfb into openshift:master Dec 21, 2016
@juanvallejo juanvallejo deleted the jvallejo/show-all-clusterquota-namespaces branch December 21, 2016 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants