-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge JUnit results from extended suites #12357
Conversation
[test] |
4e970a1
to
f8178c6
Compare
Jenkins JUnit does not handle skips in different files that have the same name, leading to invalid results. Merge all the JUnit output files into one by suite and test name. Failures override Successes, both override Skips.
f8178c6
to
919c521
Compare
Evaluated for origin test up to 919c521 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12616/) (Base Commit: d076366) |
[merge] only flakes now |
} | ||
} | ||
|
||
func main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not junitreport merge
a la junitreport summarize
?
@@ -34,4 +34,6 @@ os::log::info "" | |||
os::log::info "Running serial tests" | |||
FOCUS="${sf}" SKIP="${ss}" TEST_REPORT_FILE_NAME=core_serial os::test::extended::run -- -ginkgo.noColor -ginkgo.v -test.timeout 2h ${TEST_EXTENDED_ARGS-} || exitstatus=$? | |||
|
|||
os::test::extended::merge_junit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be trapped so it runs on failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already trap exit code
@@ -27,6 +27,7 @@ function os::test::extended::setup () { | |||
os::util::ensure::built_binary_exists 'openshift' | |||
os::util::ensure::built_binary_exists 'oadm' | |||
os::util::ensure::built_binary_exists 'oc' | |||
os::util::ensure::built_binary_exists 'junitmerge' 'tools/junitmerge' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't need to specify the path for this, it looks into tools/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do in a follow up
Evaluated for origin merge up to 919c521 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12617/) (Base Commit: d076366) (Image: devenv-rhel7_5609) |
Ensures that Jenkins does not double count skips until jenkinsci/junit-plugin#54 is merged