[3.4] Fix manifest verification if pullthrough enabled #12396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hold on merging till the master branch PR is merged and QE test it. |
legionus
changed the title
miminar
reviewed
Jan 5, 2017
| @@ -108,8 +108,12 @@ func (h *manifestSchema1Handler) Payload() (mediaType string, payload []byte, ca | |||
| func (h *manifestSchema1Handler) Verify(ctx context.Context, skipDependencyVerification bool) error { | |||
| var errs distribution.ErrManifestVerification | |||
|
|
|||
| // we want to verify that referenced blobs exist locally - thus using upstream repository object directly | |||
| repo := h.repo.Repository | |||
| // we want to verify that referenced blobs exist locally or accessible over | |||
Signed-off-by: Gladkov Alexey <[email protected]>
legionus
force-pushed
the
verify-pullthrough-1.4
branch
from
e6c0357 to
09ac7a5
Compare
|
@legionus QE finished testing, no issues found. [merge] |
legionus
changed the title
|
flake: #10228 [merge] |
mfojtik
changed the title
|
Evaluated for origin merge up to 09ac7a5 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12682/) (Base Commit: 407c344) (Image: devenv-rhel7_5639) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12395.
@mfojtik @miminar @pweil-