update instructions to redirect logs to a file #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarterclayton merge please. @danmcp fyi. |
|
Why are we redirecting the logs? So you don't have to open another terminal window? |
|
because later in the instructions it mentions looking for a particular line to confirm something happened. far easier if the logs are redirected. |
|
LGTM [merge] |
|
Evaluated for origin up to fddf0f9 |
|
Origin Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/121/) (Image: devenv-fedora_186) |
openshift-bot
pushed a commit
that referenced
this pull request
Sep 22, 2014
Merged by openshift-bot
pmorie
pushed a commit
to pmorie/origin
that referenced
this pull request
Nov 5, 2014
Update README for openstack creds file
danwinship
pushed a commit
to danwinship/origin
that referenced
this pull request
Jun 24, 2016
Fix veth host discovery for multitenant plugin
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Feb 1, 2018
…#124) While I'm not sure we're 100% ready to enforce all of these rules yet we should include this as part of our stated set of rules/goals and slowly "up" our bar as do we add the infrastructure. Signed-off-by: Doug Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.