Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: docker/distribution: 2140: Add 'ca-central-1' region for registry S3 storage driver #12451

Merged
merged 1 commit into from
Jan 17, 2017
Merged

UPSTREAM: docker/distribution: 2140: Add 'ca-central-1' region for registry S3 storage driver #12451

merged 1 commit into from
Jan 17, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jan 11, 2017

@mfojtik mfojtik changed the title UPSTREAM: docker/distribution: 2140: Add 'ca-central-1' region for registry S3 storage driver [DO_NOT_MERGE] UPSTREAM: docker/distribution: 2140: Add 'ca-central-1' region for registry S3 storage driver Jan 11, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 11, 2017

(need to verify this actually works for the new regions)

@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 12, 2017

(this doesn't work without bumping the aws-sdk-go dependency or hardcoding the fields in the endpoints there, @miminar is currently investigating this)

@miminar
Copy link

miminar commented Jan 12, 2017

I've just verified this works against ca-central-1 (aka Montreal) region. I can push and pull there without a problem.

miminar
miminar suggested changes Jan 12, 2017
View reviewed changes
vendor/github.com/docker/distribution/registry/storage/driver/s3-aws/s3.go
@@ -75,14 +75,17 @@ func init() {
"us-west-1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add us-east-2 as well please. I've tested it - works like a charm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@mfojtik
UPSTREAM: docker/distribution: 2140: Add 'ca-central-1' region for re…
e638fa4 
…gistry S3 storage driver

Signed-off-by: Michal Fojtik <[email protected]>
miminar
miminar approved these changes Jan 12, 2017
View reviewed changes
Copy link

@miminar miminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfojtik mfojtik changed the title [DO_NOT_MERGE] UPSTREAM: docker/distribution: 2140: Add 'ca-central-1' region for registry S3 storage driver UPSTREAM: docker/distribution: 2140: Add 'ca-central-1' region for registry S3 storage driver Jan 12, 2017
@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 12, 2017

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e638fa4

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12804/) (Base Commit: 38831af)

@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 17, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e638fa4

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 17, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12935/) (Base Commit: 9b125cb) (Image: devenv-rhel7_5696)

@openshift-bot openshift-bot merged commit 9a57e87 into openshift:master Jan 17, 2017
@pweil- pweil- mentioned this pull request Feb 3, 2017
Closed
@dmage dmage mentioned this pull request Dec 4, 2017
Closed
@mfojtik mfojtik deleted the add-region branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miminar miminar miminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfojtik @miminar @openshift-bot