Allow to use selector when listing clusterroles #12461
Conversation
|
@liggitt @smarterclayton PTAL |
| @@ -47,7 +47,7 @@ func (m *VirtualStorage) NewList() runtime.Object { | |||
| } | |||
|
|
|||
| func (m *VirtualStorage) List(ctx kapi.Context, options *kapi.ListOptions) (runtime.Object, error) { | |||
| policyList, err := m.PolicyStorage.ListPolicies(ctx, options) | |||
There was a problem hiding this comment.
is the same change needed for RoleBindings?
There was a problem hiding this comment.
yeah, I will check and add some tests
|
would like to see tests exercising this |
Signed-off-by: Michal Fojtik <[email protected]>
mfojtik
force-pushed
the
clusterroles-selector
branch
from
88e9b10 to
f2a189d
Compare
|
@liggitt updated. [test] |
|
Evaluated for origin test up to f2a189d |
|
LGTM, [merge] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12836/) (Base Commit: 8a41d6f) |
|
Evaluated for origin merge up to f2a189d |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12874/) (Base Commit: 4d6e336) (Image: devenv-rhel7_5676) |
|
@jmazzitelli I believe can you confirm that with this fix you can at least |
Fixes: #12450
Basically pass the ListOptions when filtering the policies.