Add golang source detector for new-app #12485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding golang source detector for oc new-app, looks for main.go and Godeps Fixes issue #12417
|
[test] |
|
Evaluated for origin test up to 77b08ef |
|
lgtm [merge] |
|
Evaluated for origin merge up to 77b08ef |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12856/) (Base Commit: 398ca1a) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12877/) (Base Commit: 13074d4) (Image: devenv-rhel7_5679) |
jawnsy
reviewed
Jan 16, 2017
| @@ -74,6 +75,11 @@ func DetectLiteralDotNet(dir string) *Info { | |||
| return detect(".net", dir, "project.json", "*.csproj") | |||
| } | |||
|
|
|||
| // DetectGolang detects Go source | |||
| func DetectGolang(dir string) *Info { | |||
| return detect("golang", dir, "main.go", "Godeps") | |||
There was a problem hiding this comment.
Can we use *.go here, similar to *.csproj for .NET? At the moment s2i-go requires a main.go file, but I would like to fix that limitation eventually, to be able to run arbitrary programs (given a go install-style path)
There was a problem hiding this comment.
Sure, please submit a PR adding *.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding golang source detector for oc new-app,
looks for main.go and Godeps
Fixes issue #12417