Uses patch instead of update to mark nodes (un)schedulable #12486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] @marun @pravisankar PTAL |
|
Evaluated for origin test up to 7ab32ff |
|
fyi @smarterclayton |
|
Generating patches by hand is generally not a great idea, but it's ok for here. |
|
Interesting. Is there anywhere else this strategy could be applied to minimize contention? |
|
continuous-integration/openshift-jenkins/test ABORTED (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12860/) (Base Commit: b7ed175) |
|
[merge] |
|
Evaluated for origin merge up to 7ab32ff |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12917/) (Base Commit: 4bae8ee) (Image: devenv-rhel7_5692) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1279303
Avoid race conditions when using
oadm manage-node --schedulableby applying a PATCH in the desired attribute instead of a full update of the node object.