ipfailover - user check script overrides default #12509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knobunc PTAL |
knobunc
requested changes
Jan 16, 2017
| @@ -44,6 +44,8 @@ function generate_global_config() { | |||
|
|
|||
| # | |||
| # Generate VRRP checker script configuration section. | |||
| # When port is 0 always pass | |||
There was a problem hiding this comment.
Actually, upon reflection, I think this is wrong.
If they give us a check script, always use it
If the port is non-zero set up the tcp check
Otherwise, skip the test
When the user supplies a check script, that check script replaces the default check script. bug bz1410721 https://bugzilla.redhat.com/show_bug.cgi?id=1410721 Signed-off-by: Phil Cameron <[email protected]>
|
@stevekuznetsov PTAL |
stevekuznetsov
approved these changes
Jan 17, 2017
|
@knobunc You still have Changes requested set... |
|
@pecameron I think you need to reload the page. I approved, but asked @stevekuznetsov for a review since he is the bash ninja. |
|
@knobunc Is this ready to merge? |
|
[merge] |
|
Evaluated for origin merge up to 82b3d97 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13000/) (Base Commit: cf4e84e) (Image: devenv-rhel7_5713) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user supplies a check script, that check script replaces the
default check script.
See openshift-docs PR 3501
bug bz1410721
https://bugzilla.redhat.com/show_bug.cgi?id=1410721
Signed-off-by: Phil Cameron [email protected]