UPSTREAM: 37986: Add clusterid, an optional parameter to storageclass.
#12556
Conversation
Signed-off-by: Humble Chirammal <[email protected]>
…rom SC individually Signed-off-by: Humble Chirammal <[email protected]>
…or gluster DP volumes Signed-off-by: Humble Chirammal <[email protected]>
|
Do you need this in 1.5 or can it wait until 1.6? |
|
he wants it in 1.5 |
| if p.provisioningConfig.clusterId != "" { | ||
| clusterIds = dstrings.Split(p.clusterId, ",") | ||
| glog.V(4).Infof("glusterfs: provided clusterids: %v", clusterIds) | ||
| } | ||
| gid64 := int64(gid) | ||
| volumeReq := &gapi.VolumeCreateRequest{Size: sz, Clusters: clusterIds, Gid: gid64, Durability: gapi.VolumeDurabilityInfo{Type: durabilityType, Replicate: gapi.ReplicaDurability{Replica: replicaCount}}} |
There was a problem hiding this comment.
do we want to implement the recent bug fix/change in Kube kubernetes/kubernetes#39844
so we can use the built volumeType from parseClassParameters?
volumeReq := &gapi.VolumeCreateRequest{Size: sz, Clusters: clusterIds, Gid: gid64, Durability: p.volumeType}
There was a problem hiding this comment.
@screeley44 no. I am still not convinced on that fix :( . We will have a discussion on this and act accordingly.
There was a problem hiding this comment.
@humblec - fair enough, but I'm wondering why are we building the volumeType in the parseClassParameters if we will not use that config object?
|
LGTM @screeley44 @humblec if upstream 39844 is needed, can you open follow up pr? |
|
lgtm |
|
[test] |
|
@rootfs sure.. I am discussing with @screeley44 . Will backport it accordingly. |
|
please hold merge. |
Signed-off-by: Humble Chirammal <[email protected]>
|
lgtm |
|
talked with humble and hchen, both are g2g on this now. PR looks good and is merged upstream. thanks guys. [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13049/) (Image: devenv-rhel7_5730) |
|
Evaluated for origin merge up to 4947de6 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 4947de6 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13049/) (Base Commit: b2508ea) |
Signed-off-by: Humble Chirammal [email protected]