use ImageStreamImport for container command lookup in oc debug #12585
Conversation
pkg/cmd/cli/cmd/debug.go
Outdated
| namespace = o.Attach.Pod.Namespace | ||
| } | ||
|
|
||
| isi, err := o.Client.ImageStreamImages(namespace).Get(isname, ref.ID) |
There was a problem hiding this comment.
You need to check that ID is set.
pkg/cmd/cli/cmd/debug.go
Outdated
| } | ||
|
|
||
| namespace := trigger.ImageChangeParams.From.Namespace | ||
| if namespace == "" { |
There was a problem hiding this comment.
We use len(namespace) == 0 by convention.
jim-minter
force-pushed
the
issue12559-fix
branch
from
17afc87 to
d9e63e0
Compare
|
@smarterclayton requested changes made |
|
Evaluated for origin test up to d9e63e0 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13478/) (Base Commit: 92ce2c9) |
|
@smarterclayton if this is good to go, please hit merge. |
|
ping @smarterclayton ... |
|
The other issue we discussed has been opened, correct? LGTM [merge] |
|
Evaluated for origin merge up to d9e63e0 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/33/) (Base Commit: 7412065) (Image: devenv-rhel7_5884) |
[test]