normalize server url before writing to config #12591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
enj
suggested changes
Jan 21, 2017
| clusters := make(map[string]*clientcmdapi.Cluster) | ||
| clusters[clusterNick] = &clientcmdapi.Cluster{ | ||
| Server: o.APIServerURL, | ||
| Server: serverNormalized, |
There was a problem hiding this comment.
A better approach would be to overwrite o.APIServerURL so that the code below sees the new value.
juanvallejo
force-pushed
the
jvallejo/normalize-config-master-url
branch
from
e6c1458 to
88f2338
Compare
|
@enj thanks, review comment addressed |
enj
approved these changes
Jan 23, 2017
|
integration check flaked on #12558 re[test] |
|
LGTM, @juanvallejo squash into one? |
juanvallejo
force-pushed
the
jvallejo/normalize-config-master-url
branch
from
88f2338 to
83fbdc8
Compare
|
@fabianofranz thanks, done! |
|
[merge] |
|
Evaluated for origin merge up to 83fbdc8 |
|
conformance check flaked on #10773 re[test] |
|
Evaluated for origin test up to 83fbdc8 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13250/) (Base Commit: c5868ac) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13281/) (Base Commit: c82fb7d) (Image: devenv-rhel7_5770) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1393943
This patch updates
$ openshift admin create-api-client-configcommand to normalize the specified server url before creating the client kubeconfig.cc @openshift/cli-review