Bump etcd to v3.1.0 GA #12600
Merged
Bump etcd to v3.1.0 GA #12600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
force-pushed
the
bump_etcd_310
branch
from
9e9e1d5 to
e22997b
Compare
|
Just a flake, @liggitt as requested. See justification for the two hacks.
|
liggitt
reviewed
Jan 23, 2017
| @@ -2960,7 +2960,7 @@ var _ grpc.ClientConn | |||
|
|
|||
| // This is a compile-time assertion to ensure that this generated file | |||
| // is compatible with the grpc package it is being compiled against. | |||
| const _ = grpc.SupportPackageIsVersion3 | |||
| const _ = grpc.SupportPackageIsVersion4 | |||
There was a problem hiding this comment.
how is this part of kube using a different version of grpc than us?
There was a problem hiding this comment.
Kube is still on etcd 3.1.0-rc1 track.
|
[test] |
|
Evaluated for origin test up to e22997b |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13184/) (Base Commit: 6822a9b) |
|
[merge] |
|
As per Jordan's verbal OK and the desire to align with what we are going to ship sooner rather than later. |
|
Evaluated for origin merge up to e22997b |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13184/) (Base Commit: fac9b78) (Image: devenv-rhel7_5757) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to workaround GRPC incompatibilities with CRI and rkt, neither of which we are actually using in 1.5.
[test]