Remove unnecessary copyright remarks in our code #12613
Conversation
| @@ -230,7 +230,7 @@ func NewCmdCompletion(fullName string, f *clientcmd.Factory, out io.Writer) *cob | |||
| cmdHelpName = "openshift" | |||
| } | |||
|
|
|||
| cmd := kcmd.NewCmdCompletion(f, out) | |||
| cmd := kcmd.NewCmdCompletion(f, out, "\n") | |||
There was a problem hiding this comment.
Why \n and not just the empty string?
There was a problem hiding this comment.
Because empty triggers to use a default boilerplate.
There was a problem hiding this comment.
How else would you think of doing it upstream?
There was a problem hiding this comment.
I think what you did upstream is good and the right way to do it. For aesthetics, I would prefer to avoid a newline but I guess it's not easily doable.
There was a problem hiding this comment.
Initially I went with a space, but that looked bad, so I fall back to newline, which looks much better in the generated file.
|
@ncdc any other concerns? |
|
LGTM |
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 6d7beab |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13185/) (Base Commit: 6822a9b) |
|
Flake #10773 [merge] |
|
Evaluated for origin merge up to 6d7beab |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13213/) (Base Commit: b0f2c58) (Image: devenv-rhel7_5757) |
@ncdc one of post-rebase task, ptal