Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regressed contextdir buildconfig parameter behavior #12628

Merged
merged 2 commits into from
Jan 26, 2017
Merged

fix regressed contextdir buildconfig parameter behavior #12628

merged 2 commits into from
Jan 26, 2017

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jan 23, 2017 •
edited
Loading

@bparees bparees changed the title fix regressed contextdir buildconfig parameter behavior [WIP] fix regressed contextdir buildconfig parameter behavior Jan 23, 2017
@bparees
Copy link
Contributor Author

bparees commented Jan 23, 2017

(working on extended tests for this)

@bparees bparees changed the title [WIP] fix regressed contextdir buildconfig parameter behavior fix regressed contextdir buildconfig parameter behavior Jan 24, 2017
@bparees
Copy link
Contributor Author

bparees commented Jan 24, 2017

@csrwng ptal

@bparees
Copy link
Contributor Author

bparees commented Jan 24, 2017

[test]

@bparees
Copy link
Contributor Author

bparees commented Jan 24, 2017 •
edited
Loading

[testextended][extended:core(image_ecosystem)]

@bparees bparees force-pushed the context_dir branch 3 times, most recently from 2c63c3b to 65bea9e Compare January 24, 2017 20:47
csrwng
csrwng reviewed Jan 24, 2017
View reviewed changes
Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 91c6017

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13293/) (Base Commit: a32dda3)

@bparees
Copy link
Contributor Author

bparees commented Jan 25, 2017

extended builds failure is a known flake.

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 91c6017

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/1033/) (Base Commit: f762dc6) (Extended Tests: core(image_ecosystem))

@bparees
Copy link
Contributor Author

bparees commented Jan 25, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 91c6017

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 26, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13323/) (Base Commit: 9c10505) (Image: devenv-rhel7_5780)

@openshift-bot openshift-bot merged commit 57f171c into openshift:master Jan 26, 2017
@bparees bparees deleted the context_dir branch January 26, 2017 18:51
@jerboaa jerboaa mentioned this pull request Feb 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng csrwng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bparees @openshift-bot @csrwng