Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve bash completions for namespace flags #12630

Merged
merged 2 commits into from
Jan 28, 2017
Merged

improve bash completions for namespace flags #12630

merged 2 commits into from
Jan 28, 2017

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Jan 23, 2017 •
edited
Loading

Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1405961

Adds support for bash and zsh --namespace flag value completion.
Will suggest all available namespaces for a --namespace flag, and suggest all resources in the chosen namespace

@openshift/cli-review

@juanvallejo juanvallejo force-pushed the jvallejo/improve-bash-completions branch 2 times, most recently from acabdfb to f3657cb Compare January 24, 2017 15:07
@juanvallejo
Copy link
Contributor Author

[test]

@juanvallejo
Copy link
Contributor Author

@fabianofranz ./hack/verify-generated-completions.sh passes locally, however the jenkins / travis test does not seem to be generating up to date completions

@juanvallejo juanvallejo force-pushed the jvallejo/improve-bash-completions branch 2 times, most recently from 68560c1 to d21bd68 Compare January 26, 2017 19:31
@fabianofranz
Copy link
Member

@juanvallejo passed here locally too.

@juanvallejo
Copy link
Contributor Author

@fabianofranz hm, I rebased with latest master in hopes that will fix generated completions check. I'll re[test] once more

@fabianofranz
Copy link
Member

[merge]

@juanvallejo
Copy link
Contributor Author

conformance flaked on #11887 re[test]

@fabianofranz
Copy link
Member

[merge]

@juanvallejo
improve bash completions for namespace flags
eb87135 
adds support for bash and zsh --namespace flag value completion
@juanvallejo
Update completions
0e8f8c2
@juanvallejo juanvallejo force-pushed the jvallejo/improve-bash-completions branch from d21bd68 to 0e8f8c2 Compare January 27, 2017 18:17
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 0e8f8c2

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13372/) (Base Commit: 83e2ef6)

@fabianofranz
Copy link
Member

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 0e8f8c2

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13391/) (Base Commit: 7eb072f) (Image: devenv-rhel7_5799)

@openshift-bot openshift-bot merged commit db0e14f into openshift:master Jan 28, 2017
@juanvallejo juanvallejo deleted the jvallejo/improve-bash-completions branch January 30, 2017 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanvallejo @fabianofranz @openshift-bot