Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch empty extension files to return 200 with Content-Length zero #12644

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Switch empty extension files to return 200 with Content-Length zero #12644

merged 1 commit into from
Jan 24, 2017

Conversation

jwforres
Copy link
Member

No description provided.

@jwforres jwforres requested a review from spadgett January 24, 2017 14:17
@spadgett
Copy link
Member

What cache headers are generated now when there is no content?

@jwforres
Copy link
Member Author

All the headers:

cache-control:public, max-age=0, must-revalidate
content-encoding:gzip
content-length:23
content-type:application/javascript; charset=utf-8
date:Tue, 24 Jan 2017 14:12:54 GMT
etag:W/"d41d8cd98f00b204e9800998ecf8427e_677a6970"
status:200
vary:Accept-Encoding
x-content-type-options:nosniff
x-frame-options:DENY
x-xss-protection:1; mode=block

@spadgett
Copy link
Member

Does that response have content? Otherwise I'd expect Content-Length: 0

spadgett
spadgett approved these changes Jan 24, 2017
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@jwforres
Copy link
Member Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to a228bec

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to a228bec

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13246/) (Base Commit: c5868ac)

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13261/) (Base Commit: 9b9b5e9) (Image: devenv-rhel7_5765)

@openshift-bot openshift-bot merged commit 2ea8719 into openshift:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwforres @spadgett @openshift-bot