start the next serial build immediately after a build is canceled #12699
Conversation
|
[testextended][extended:core(builds)] |
|
@csrwng ptal |
|
[test] |
| @@ -273,6 +276,19 @@ func (bc *BuildController) resolveOutputDockerImageReference(build *buildapi.Bui | |||
| return ref, nil | |||
| } | |||
|
|
|||
| func handleBuildCompletion(build *buildapi.Build, runPolicies []policy.RunPolicy) { | |||
| runPolicy := policy.ForBuild(build, runPolicies) | |||
There was a problem hiding this comment.
looking at this code again, should we not determine if the build is complete first before getting the run policy and calling onComplete on it?
There was a problem hiding this comment.
yeah that does seem like a logical optimization.
|
Just one question, otherwise LGTM |
|
@csrwng updated |
|
LGTM |
|
Evaluated for origin test up to 647f328 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13383/) (Base Commit: e4e69b2) |
|
Evaluated for origin testextended up to 647f328 |
|
continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/1044/) (Base Commit: ae7e34f) (Extended Tests: core(builds)) |
|
[merge] |
1 similar comment
|
[merge] |
|
Evaluated for origin merge up to 647f328 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13403/) (Base Commit: 33c36f4) (Image: devenv-rhel7_5807) |
No description provided.