cluster up: remove hardcoded docker root mount #12744
Conversation
|
@bparees ptal |
| @@ -258,6 +259,7 @@ func (h *Helper) Start(opt *StartOptions, out io.Writer) (string, error) { | |||
| binds = append(binds, fmt.Sprintf("%[1]s:%[1]s%[2]s", opt.HostVolumesDir, propagationMode)) | |||
| } | |||
| env = append(env, opt.Environment...) | |||
| binds = append(binds, fmt.Sprintf("%[1]s:%[1]s", opt.DockerRoot)) | |||
There was a problem hiding this comment.
where's the /var/lib/docker mount that this is replacing?
There was a problem hiding this comment.
arrgh, didn't remove it. It's at the beginning of this file. Will update.
Uses the docker root retrieved from docker info to mount that into the origin container, instead of hardconding '/var/lib/docker'
csrwng
force-pushed
the
clusterup_mount_docker_root
branch
from
d6f8478 to
08bfa3d
Compare
|
lgtm |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13461/) (Image: devenv-rhel7_5825) |
|
Evaluated for origin merge up to 08bfa3d |
|
[Test]ing while waiting on the merge queue |
|
flake #11315 |
|
Evaluated for origin test up to 08bfa3d |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13461/) (Base Commit: 6b6610a) |
1 similar comment
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13461/) (Base Commit: 6b6610a) |
Uses the docker root retrieved from docker info to mount that into
the origin container, instead of hardconding '/var/lib/docker'
Fixes #12111