Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image(router): Add logging facility to router tmpl #12795

Merged
merged 1 commit into from
Feb 8, 2017
Merged

image(router): Add logging facility to router tmpl #12795

merged 1 commit into from
Feb 8, 2017

Conversation

tripledes
Copy link
Contributor

  • Allow to set logging facility other than local1, defaulting to local1
    unless otherwise specified

Fixes #12794

* Allow to set logging facility other than local1, defaulting to local1
unless otherwise specified
@tripledes
Copy link
Contributor Author

Checks failed, although I cannot see how it's related to my change, any hint?

Thanks!

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knobunc
Copy link
Contributor

knobunc commented Feb 3, 2017

[test]

@imcsk8
Copy link
Contributor

imcsk8 commented Feb 8, 2017

The errors in the tests don't seem related to the PR.

@knobunc
Copy link
Contributor

knobunc commented Feb 8, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to c01fab1

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13704/) (Base Commit: 6c0ca75)

@knobunc
Copy link
Contributor

knobunc commented Feb 8, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to c01fab1

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13717/) (Base Commit: abd25eb) (Image: devenv-rhel7_5880)

@openshift-bot openshift-bot merged commit 421e4d0 into openshift:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants