-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image(router): Add logging facility to router tmpl #12795
image(router): Add logging facility to router tmpl #12795
Conversation
* Allow to set logging facility other than local1, defaulting to local1 unless otherwise specified
Checks failed, although I cannot see how it's related to my change, any hint? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[test] |
The errors in the tests don't seem related to the PR. |
[test] |
Evaluated for origin test up to c01fab1 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13704/) (Base Commit: 6c0ca75) |
[merge] |
Evaluated for origin merge up to c01fab1 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13717/) (Base Commit: abd25eb) (Image: devenv-rhel7_5880) |
unless otherwise specified
Fixes #12794