-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple heapster and prometheus examples as optional templates to kube-system #12844
Add simple heapster and prometheus examples as optional templates to kube-system #12844
Conversation
[test] |
@@ -72,7 +73,7 @@ objects: | |||
imagePullPolicy: IfNotPresent | |||
name: prometheus | |||
ports: | |||
- containerPort: 9090 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The process inside the pod still listens on 9090. There's likely something you need to change in the config to have it listen on 8080.
The cluster up parts LGTM And an observation... as an admin user I was not able to instantiate the heapster template through the web console because the web console doesn't know about clusterrolebindings. /cc @jwforres |
b62e6fa
to
ed14b27
Compare
Fixed to go back to 9090, [merge]
…On Wed, Feb 8, 2017 at 1:03 PM, Cesar Wong ***@***.***> wrote:
The cluster up parts LGTM
Just one comment on the prometheus template.
And an observation... as an admin user I was not able to instantiate the
heapster template through the web console because the web console doesn't
know about clusterrolebindings. /cc @jwforres
<https://github.com/jwforres>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12844 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p9dhZVMBhHj8Ik2u4S5sIk1q8_DZks5ragNcgaJpZM4L5Aow>
.
|
Evaluated for origin test up to ed14b27 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13732/) (Image: devenv-rhel7_5882) |
Evaluated for origin merge up to ed14b27 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13732/) (Base Commit: 863f435) |
Gives admins simple Kube equivalent capabilities in Origin