Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple heapster and prometheus examples as optional templates to kube-system #12844

Merged
merged 3 commits into from
Feb 9, 2017

Conversation

smarterclayton
Copy link
Contributor

Gives admins simple Kube equivalent capabilities in Origin

@smarterclayton
Copy link
Contributor Author

[test]

@smarterclayton
Copy link
Contributor Author

@csrwng

@@ -72,7 +73,7 @@ objects:
imagePullPolicy: IfNotPresent
name: prometheus
ports:
- containerPort: 9090
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process inside the pod still listens on 9090. There's likely something you need to change in the config to have it listen on 8080.

@csrwng
Copy link
Contributor

csrwng commented Feb 8, 2017

The cluster up parts LGTM
Just one comment on the prometheus template.

And an observation... as an admin user I was not able to instantiate the heapster template through the web console because the web console doesn't know about clusterrolebindings. /cc @jwforres

@smarterclayton smarterclayton force-pushed the bootstrap_monitoring branch 2 times, most recently from b62e6fa to ed14b27 Compare February 8, 2017 21:07
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Feb 8, 2017 via email

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to ed14b27

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 8, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13732/) (Image: devenv-rhel7_5882)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to ed14b27

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13732/) (Base Commit: 863f435)

@openshift-bot openshift-bot merged commit 4151dc8 into openshift:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants