Deprecate User.groups field

[liggitt]

We meant to deprecate this in 1.1 when we introduced the Group object, and forgot.

It causes confusion, and is not where we would want per-session group membership to live (that would likely go on an identity or token object instead).

Mark as deprecated now so we can migrate/remove it in a few releases.

[liggitt]

cc @smarterclayton @deads2k @enj

[deads2k]

lgtm

[liggitt]

[merge]

[enj]

Do we not have any specific doc notation or struct tag to mark a field as deprecated?

[liggitt]

other than marking it deprecated in the field comment (which filters to swagger, etc)? no

[deads2k]

Do we not have any specific doc notation or struct tag to mark a field as deprecated?

What do you think this is, the 80s? Golang won't get there for another decade.

[enj]

I had seen this earlier and did not know if it was a notation that we followed:

The strikethrough is nice.

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13711/) (Image: devenv-rhel7_5882)

[openshift-bot]

Evaluated for origin merge up to 487c698

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to 487c698

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13711/) (Base Commit: 76141a4)