Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special handling of --token and --context for whoami #12872

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Remove special handling of --token and --context for whoami #12872

merged 1 commit into from
Feb 11, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Feb 8, 2017 •
edited
Loading

Remove the deprecated flags so we can specify client credentials directly with whoami

@liggitt
Copy link
Contributor Author

liggitt commented Feb 8, 2017

@deads2k @juanvallejo

@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2017

@liggitt anything you need to do for a release-note?

@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2017

lgtm, just the question about release note

@juanvallejo
Copy link
Contributor

lgtm as well

@juanvallejo
Copy link
Contributor

[test]

@liggitt
Copy link
Contributor Author

liggitt commented Feb 8, 2017

in 1.4 release notes in openshift/openshift-docs#2933 (comment)

will add to 1.5 release notes as well

@liggitt
Copy link
Contributor Author

liggitt commented Feb 8, 2017

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to abcee6f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/69/) (Base Commit: 898266a)

@stevekuznetsov
Copy link
Contributor

@openshift-bot, the last build failed from the following flakes:

re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to abcee6f

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 11, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/138/) (Base Commit: 364a056) (Image: devenv-rhel7_5900)

@openshift-bot openshift-bot merged commit 74771e1 into openshift:master Feb 11, 2017
@liggitt liggitt deleted the remove-whoami-deprecated branch February 20, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @deads2k @juanvallejo @openshift-bot @stevekuznetsov