-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort List
for virtual resources
#12881
Conversation
Signed-off-by: Monis Khan <[email protected]>
[test] |
Lgtm. Can you check the other virtual resources for any others we can sort? |
Flake is openshift/origin-gce#12 |
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
List
for Role virtual storageList
for virtual resources
@deads2k any other virtual resource for me to sort? |
Evaluated for origin test up to 80ab91d |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13744/) (Base Commit: 863f435) |
LGTM |
role, clusterrole, rolebinding, and clusterrolebinding are the only ones that come to mind. |
@smarterclayton do you want to keep these as separate commits or a single one? |
Separate. |
OK, then this is ready for merge if you are good. |
LGTM [merge] |
Evaluated for origin merge up to 80ab91d |
continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/76/) (Base Commit: 146ff41) |
Fixes #12792
@smarterclayton PTAL
Signed-off-by: Monis Khan [email protected]