Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort List for virtual resources #12881

Merged
merged 3 commits into from
Feb 10, 2017

Conversation

enj
Copy link
Contributor

@enj enj commented Feb 9, 2017

Fixes #12792

$ oc get clusterrole
NAME
admin
basic-user
cluster-admin
cluster-reader
cluster-status
edit
registry-admin
registry-editor
registry-viewer
self-access-reviewer
self-provisioner
storage-admin
sudoer
system:build-controller
system:build-strategy-custom
system:build-strategy-docker
system:build-strategy-jenkinspipeline
system:build-strategy-source
system:certificate-signing-controller
system:daemonset-controller
system:deployer
system:deployment-controller
system:deploymentconfig-controller
system:discovery
system:disruption-controller
system:endpoint-controller
system:gc-controller
system:hpa-controller
system:image-auditor
system:image-builder
system:image-pruner
system:image-puller
system:image-pusher
system:image-signer
system:job-controller
system:master
system:namespace-controller
system:node
system:node-admin
system:node-bootstrapper
system:node-proxier
system:node-reader
system:oauth-token-deleter
system:pv-attach-detach-controller
system:pv-binder-controller
system:pv-provisioner-controller
system:pv-recycler-controller
system:registry
system:replicaset-controller
system:replication-controller
system:router
system:sdn-manager
system:sdn-reader
system:service-ingress-ip-controller
system:service-load-balancer-controller
system:service-serving-cert-controller
system:statefulset-controller
system:unidling-controller
system:webhook
view

@smarterclayton PTAL

Signed-off-by: Monis Khan [email protected]

@enj
Copy link
Contributor Author

enj commented Feb 9, 2017

[test]

@smarterclayton
Copy link
Contributor

Lgtm. Can you check the other virtual resources for any others we can sort?

@smarterclayton
Copy link
Contributor

Flake is openshift/origin-gce#12

@enj enj changed the title Sort List for Role virtual storage Sort List for virtual resources Feb 9, 2017
@enj
Copy link
Contributor Author

enj commented Feb 9, 2017

@deads2k any other virtual resource for me to sort?

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 80ab91d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13744/) (Base Commit: 863f435)

@mfojtik
Copy link
Contributor

mfojtik commented Feb 9, 2017

LGTM

@deads2k
Copy link
Contributor

deads2k commented Feb 9, 2017

role, clusterrole, rolebinding, and clusterrolebinding are the only ones that come to mind.

@enj
Copy link
Contributor Author

enj commented Feb 9, 2017

@smarterclayton do you want to keep these as separate commits or a single one?

@smarterclayton
Copy link
Contributor

Separate.

@enj
Copy link
Contributor Author

enj commented Feb 9, 2017

Separate.

OK, then this is ready for merge if you are good.

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 80ab91d

@openshift-bot openshift-bot merged commit a223cb6 into openshift:master Feb 10, 2017
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/76/) (Base Commit: 146ff41)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants