add add-cluster-role-to-user support for -z #12902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/cmd/admin/policy/modify_roles.go
Outdated
| @@ -252,10 +256,12 @@ func NewCmdRemoveClusterRoleFromUser(name, fullName string, f *clientcmd.Factory | |||
| }, | |||
| } | |||
|
|
|||
| cmd.Flags().StringSliceVarP(&saNames, "serviceaccount", "z", saNames, "service account in the current cluster to use as a user") | |||
There was a problem hiding this comment.
in the current namespace
pkg/cmd/admin/policy/modify_roles.go
Outdated
| @@ -204,6 +205,8 @@ func NewCmdAddClusterRoleToUser(name, fullName string, f *clientcmd.Factory, out | |||
| }, | |||
| } | |||
|
|
|||
| cmd.Flags().StringSliceVarP(&saNames, "serviceaccount", "z", saNames, "service account in the current cluster to use as a user") | |||
There was a problem hiding this comment.
in the current namespace
juanvallejo
force-pushed
the
jvallejo/add-sa-support-oadm-add-cluster-role
branch
from
6267484 to
d14f658
Compare
|
[test] |
juanvallejo
force-pushed
the
jvallejo/add-sa-support-oadm-add-cluster-role
branch
from
d14f658 to
c2928ac
Compare
juanvallejo
force-pushed
the
jvallejo/add-sa-support-oadm-add-cluster-role
branch
from
c2928ac to
f661068
Compare
|
check_future flaked on #12911 re[test] |
|
Evaluated for origin test up to f661068 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/122/) (Base Commit: 1d1fc72) |
|
@smarterclayton or @enj are there any more comments for this patch? Thanks! |
|
LGTM [merge] |
|
Evaluated for origin merge up to f661068 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/159/) (Base Commit: 4e48fca) (Image: devenv-rhel7_5907) |
juanvallejo
deleted the
jvallejo/add-sa-support-oadm-add-cluster-role
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12791
cc @smarterclayton @enj