a split on string can give empty elements - fix bz1421572 #12944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecameron
approved these changes
Feb 13, 2017
knobunc
approved these changes
Feb 13, 2017
|
[test] |
|
Evaluated for origin test up to 6ea8ae8 |
|
@knobunc A unit test case will not be useful, the error is at F5 REST api (empty condition is not ignored). |
|
@rajatchopra got it. Thanks |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/179/) (Base Commit: bd3e362) |
|
[merge] |
|
Evaluated for origin merge up to 6ea8ae8 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/211/) (Base Commit: 2d3b39c) (Image: devenv-rhel7_5915) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1421572
A strings.split("/") gives two elements, both empty. And we would barf without this fix. Also for any path that ends with a "/" will give an empty last element.
cc @knobunc @openshift/networking