Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing newlines in oc tag #12948

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Add missing newlines in oc tag #12948

merged 1 commit into from
Feb 20, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 14, 2017

@miminar ptal

@mfojtik @pweil- for approval this is simple fix, but makes the UX sooo much better :)

@soltysh
Copy link
Contributor Author

soltysh commented Feb 14, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to f52c0a1

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/185/) (Base Commit: bd3e362)

@soltysh
Copy link
Contributor Author

soltysh commented Feb 14, 2017

@stevekuznetsov I'm looking into https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/185/ and nothing failed, but bot states differently, what did you do to him 😉

@soltysh soltysh mentioned this pull request Feb 14, 2017
Closed
miminar
miminar approved these changes Feb 14, 2017
View reviewed changes
Copy link

@miminar miminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfojtik
Copy link
Contributor

mfojtik commented Feb 14, 2017

Approved for 1.5 (new line fixed needs to merge ASAP ;-)

[merge]

@mfojtik mfojtik added this to the 1.5.0 milestone Feb 14, 2017
@stevekuznetsov
Copy link
Contributor

Very weird -- if we see the bot get it wrong again I'll dig more, never seen that before.

@soltysh
Copy link
Contributor Author

soltysh commented Feb 16, 2017

Previous problem was fixed.

[merge]

@soltysh
Copy link
Contributor Author

soltysh commented Feb 20, 2017

Flake #10773.

[merge]

@soltysh
Copy link
Contributor Author

soltysh commented Feb 20, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to f52c0a1

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/353/) (Base Commit: e376a9a) (Image: devenv-rhel7_5942)

@openshift-bot openshift-bot merged commit 41c7fe9 into openshift:master Feb 20, 2017
@soltysh soltysh deleted the tag_newlines branch February 20, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miminar miminar miminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@soltysh @openshift-bot @mfojtik @stevekuznetsov @miminar