Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "." to "-" in generated hostnames for routes #12976

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Change "." to "-" in generated hostnames for routes #12976

merged 1 commit into from
Feb 20, 2017

Conversation

JacobTanenbaum
Copy link
Contributor

if a route is named example.test the default generated hostname is

example.test-default.router.default.svc.cluster.local

This changes the default generated hostname to

example-test-default.router.default.svc.cluster.local

Bug 1414956 Link

@JacobTanenbaum
Change "." to "-" in generated hostnames for routes
23ce2ca 
if a route is named example.test the default generated hostname is

example.test-default.router.default.svc.cluster.local

This changes the default generated hostname to

example-test-default.router.default.svc.cluster.local

Bug 1414956
@JacobTanenbaum
Copy link
Contributor Author

@openshift/networking PTAL.

Does this also need to be changed for the --force-subdomain case?

rajatchopra
rajatchopra approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ramr
ramr approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@ramr ramr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramr
Copy link
Contributor

ramr commented Feb 15, 2017

@JacobTanenbaum so the --force-subdomain / template is user specified and the template could say $name-$namespace or something else with dots and there's the ingress case as well. This https://github.com/openshift/origin/blob/master/pkg/cmd/infra/router/router.go#L94 might be a good spot to address that maybe.

@knobunc
Copy link
Contributor

knobunc commented Feb 15, 2017

@JacobTanenbaum Looks @ramr agrees we probably should change the --force-subdomain case too.

@knobunc
Copy link
Contributor

knobunc commented Feb 15, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 23ce2ca

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/242/) (Base Commit: c8e60fe)

1 similar comment
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/242/) (Base Commit: c8e60fe)

@eparis
Copy link
Member

eparis commented Feb 20, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 23ce2ca

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/362/) (Base Commit: 41c7fe9) (Image: devenv-rhel7_5943)

@openshift-bot openshift-bot merged commit ffdaf6d into openshift:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramr ramr ramr approved these changes

@rajatchopra rajatchopra rajatchopra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JacobTanenbaum @ramr @knobunc @openshift-bot @eparis @rajatchopra