add closure that guarantees mutex unlock in loop #12980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff is significantly easier to see when ignoring whitespace. |
|
[test] |
|
Yeah the continue was broken. LGTM |
| @@ -431,6 +431,7 @@ func (o *ObserveOptions) Run() error { | |||
| go func() { | |||
| <-time.After(o.exitAfterPeriod) | |||
| lock.Lock() | |||
| defer lock.Unlock() | |||
There was a problem hiding this comment.
This is unnecessary because we os.Exit(0). It doesn't hurt, so not an issue.
|
[merge] |
|
flaked on #12923 re[test] |
|
Evaluated for origin test up to 8d7e9d6 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/265/) (Base Commit: 19aa349) |
|
flaked on #12784 (comment) re[merge] |
|
Evaluated for origin merge up to 8d7e9d6 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/320/) (Base Commit: aa49370) (Image: devenv-rhel7_5932) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #12930
Based on output from the linked test flake:
It is a possibility that the test is hanging for multiple hours based on a deadlock happening. This patch eliminates that possibility.
cc @openshift/cli-review @enj @smarterclayton