Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in router code #12983

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Fix typos in router code #12983

merged 1 commit into from
Feb 23, 2017

Conversation

louyihua
Copy link
Contributor

Various typos, most in comments, are fixed.
And the unnecessary "_" receiver is also removed.

@pweil-
Copy link

pweil- commented Feb 16, 2017

[test]

Copy link

@pweil- pweil- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louyihua
Copy link
Contributor Author

Maybe this can be merged?

@pweil-
Copy link

pweil- commented Feb 21, 2017

[merge]

@louyihua
Copy link
Contributor Author

Seems weird failure?

@pweil-
Copy link

pweil- commented Feb 22, 2017

#10489
#12923

re[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 22, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/489/) (Image: devenv-rhel7_5968)

@louyihua
Copy link
Contributor Author

Seems still the same failure?
Rebased to the current master, hope this will be fine.

@pweil-
Copy link

pweil- commented Feb 23, 2017

let's try this again...

re[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 6cf9ce3

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/489/) (Base Commit: eaad39d)

@pweil-
Copy link

pweil- commented Feb 23, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 6cf9ce3

@openshift-bot openshift-bot merged commit 8e6abf3 into openshift:master Feb 23, 2017
@louyihua louyihua deleted the typo_fix branch February 24, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants