Ensure RPMs are only build from clean git trees #13000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hack/build-rpm-release.sh
Outdated
| @@ -18,6 +18,9 @@ fi | |||
|
|
|||
| os::log::info 'Building Origin release RPMs with tito...' | |||
| os::build::get_version_vars | |||
| if [[ "${OS_GIT_TREE_STATE}" == "drity" ]]; then | |||
The `tito` process for building RPMs will not incorporate any changes that are not committed in the git tree, so if we notice that the git three state is dirty during the RPM build, we should fail early and ask the user to commit their changes first before re-trying the build. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/ensure-clean-tree
branch
from
d76d3f4 to
cec748f
Compare
|
Evaluated for origin test up to cec748f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/303/) (Base Commit: 774a283) |
|
[merge] |
|
@openshift-bot, the last build failed from the following flakes:
re[merge] |
|
Evaluated for origin merge up to cec748f |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/351/) (Base Commit: cf7e336) (Image: devenv-rhel7_5941) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
titoprocess for building RPMs will not incorporate any changesthat are not committed in the git tree, so if we notice that the git
three state is dirty during the RPM build, we should fail early and
ask the user to commit their changes first before re-trying the build.
Signed-off-by: Steve Kuznetsov [email protected]
/cc @smarterclayton
[test]